Updated copyright notices to include the year 2018.

global: Rename client_connection_type to doveadm_connection_type

doveadm: Reorder includes This makes next commit possible

doveadm: mail: Removed redundant cur_username field from struct doveadm_mail_cmd_context.

doveadm: mail: Removed redundant cur_client_ip field from struct doveadm_mail_cmd_context.

doveadm: mail: Removed struct doveadm_cmd_context function parameters that are now useless. It can be accessed from struct doveadm_mail_cmd_context.

doveadm: Changed command contexts to contain the input, output, and connection type values directly. Before, it used a direct pointer to the connection. It used also flags to indicate the connection type, which is now consolidated in the connection type enum.

doveadm-mail: Handle parse_arg return value Invalid parameters did not cause error. Broken in fa6b2cbb3

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

doveadm: mailbox_list_index_very_dirty_syncs disabled for force-resync prerun of cmd force-resync sets mailbox_list_index_very_dirty_syncs to no for mail_storage_service_user befor mail_user is allocated.

doveadm force-resync: Skip autocreated mailboxes that don't exist yet. Since they don't exist, there's nothing to resync in them either. This avoids unnecessarily creating them.

global: Add mailbox_set_reason() calls Added to the most important places.

global: Log internal storage error on failure

global: Log mailbox_list internal errors

doveadm: Do not crash doveadm-server if input file missing save commands expects valid input file for it to work, if we are not running for cli, and input file is not provided, provide EINVAL error to caller via i_stream_error.

lib-storage & imap: add MAIL_ERROR_UNAVAILABLE as [UNAVAILABLE] [UNAVAILABLE] is defined in RFC 5530 and we were just missing a MAIL_ERROR_* constant to make use of it.

doveadm: Ensure -- is added to command line before positional arguments This prevents parser from choking on dash.

doveadm: Fix allow-empty-mailbox-name handling It was supposed to be handled for metadata commands only. Broken in 26c41874cf6019c3e39f0ed630b2a07a92b2635f

global: Replace mail_storage_service_user_free() with _unref()

lib-storage: Add explicit MAIL_ERROR_LOOKUP_ABORT error The MAIL_ERROR_NOTPOSSIBLE was a bit too generic to assume to mean the same thing. It doesn't look like there are any external plugins that break because of this change.

lib-storage: Add MAIL_ERROR_LIMIT

doveadm: Add explicit mail_storage_init/deinit() calls This mainly prevents losing hooks that were registered by doveadm plugins. Otherwise what happens is: - mail_plugins are unloaded and they unregister their hooks - doveadm plugins (e.g. doveadm_sieve) are NOT unloaded - mail_storage_deinit() frees all the registered hooks - next mail_storage_init() initializes all new hooks - All mail_plugins are loaded and they register again their hooks - doveadm plugins are NOT re-loaded or re-initialized, so their existing hooks were lost.

doveadm: Added "mailbox path" command This allows easily printing a path for a mailbox, index, control dir, etc.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

doveadm-mail: Set exit code to EX_TEMPFAIL on timeout When running `doveadm save` command on proxy/director and the remote command execution times out, exit code must be set to EX_TEMPFAIL. Fixes Panic: file doveadm-mail.c: line 405 (doveadm_mail_next_user): assertion failed: (ctx->exit_code != 0)

doveadm: Rewind input early enough Command input needs to be rewinded earlier in doveadm_mail_next_user.

global: Make sure i_stream_read() calls handle 0 and -2 return values correctly.

doveadm: allow access to server attributes via empty mailbox name

doveadm: Fixed -A and -u wildcard handling with server connections.

doveadm: Pass connection to mail context

doveadm: Extra safety - initialize cmd_input_fd to -1 Just to be sure it's never attempted to be accessed as 0 (stdin) before being initialized. (It didn't happen with current code as far as I know.)

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

lib-storage: mail_storage_service_next() now returns error string.

doveadm: Fixed sending command -parameters to doveadm-server

doveadm-mailbox: Add update subcommand

doveadm -u: Use mail_storage_service_all_init_mask()

doveadm-mail: Honor -u flag on v1 commands

doveadm-mail: Initialize missing cmd context username Fixes assert-crash in doveadm_mail_single_user()

doveadm-mail: Don't lose rip/lip/lport/rport in passdb lookups for doveadm TCP connections

doveadm: Fixed reading USER environment for v1 commands.

doveadm: Fixed adding username header to commands iterating through multiple users.

doveadm-server: v2 mail commands weren't doing a userdb lookup.

doveadm: Getting user from USER environment wasn't done in the right place. doveadm_mail_cmdline_init() is also called when parsing commands from doveadm-server. The USER environment is supposed to be read only from doveadm command line.

doveadm: Renamed long parameter names.

doveadm-server: Drop privileges only temporarily when running mail commands. This allows running mail commands for multiple users within the same doveadm connection.

doveadm-mail: Rename ctx to mctx to separate from cctx

doveadm: Changed v2 command APIs to be easier to use.

doveadm: Minor code cleanup - use arg-> instead of argv[i].

doveadm: Fixed parsing field/flag/file parameters.

doveadm: Pass through mail_storage_service_input fields in doveadm_cmd_attributes

doveadm-flags: Support giving flags as an array.

doveadm-copymove: Use ver2 structures

doveadm: Fully populate mail_cmd in ver2 wrapper

doveadm-search: Use ver2 structures

doveadm-purge: Use ver2 structures

doveadm-force-resync: Use ver2 structures

doveadm-import: Use ver2 structures

doveadm-flags: Use ver2 structures

doveadm-expunge: Use ver2 structures

doveadm-deduplicate: Use ver2 structures

doveadm-altmove: Use ver2 structures

doveadm: Remove return value from ver2 cmd() - doveadm_exit_code is enough

doveadm: Fixed usage printing for ver2 commands

doveadm: Define DOVEADM_CMD_MAIL_USAGE_PREFIX, which v2 commands use as their usage prefix. This allows implementing the next changeset without kludging.

doveadm-index: Use ver2 structures

doveadm-save: Use ver2 command structure

doveadm: Added support for "file" parameters

doveadm: Fixed double-free when using -F parameter

doveadm: Fixed memory leaks when ver2 command parsing fails with invalid parameter.

doveadm-mail: Fixed common parameters to use correct names as in DOVEADM_CMD_MAIL_COMMON

doveadm-fetch: Use ver2 structures

doveadm: Add kludge to support field array to fieldstr conversion

doveadm: Use char type for short options instead of a string. The ":" = "has parameters" can be determined from the type. Also removed "?" checks since it wasn't actually used.

doveadm: Use ver2 structures for all "doveadm mailbox *" commands.

doveadm: Add infrastructure for doveadm_cmd_ver2 Version 2 commands have named parameters, which also have types. This is especially useful for reading input from HTTP/JSON API. This also simplifies the parameter parsing for command line input. For v2.3 the plan is to replace all the old doveadm_cmds with this new version and get rid of the _ver2 suffixes. But for now we'll have two versions of commands. For backwards compatibility with old commands we have also implemented wrappers so that v2 structs can be defined and there's a function to convert the named parameters to old v1 style args[] string, so the old command handlers can still be run. This will also be removed in v2.3. This change also adds requirement for getopt_long(). It's already available in all the Linuxes and BSDs, so this shouldn't be too big of a requirement. Other systems can install it from an external library.

doveadm: If user lookup fails, log an error but don't kill the process.

doveadm: Code cleanup - Removed passing through unnecessary argv parameter

doveadm: Code cleanup - move code to doveadm_mail_cmd_exec() No functional changes.

doveadm: Enable SIGINT and SIGTERM signal handler for all doveadm mail commands. Most importantly this allows stopping dsync.

doveadm: Make sure all mail storage hooks are freed at deinit.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

doveadm: Make sure we can't accidentally add duplicate getopt args.

doveadm: Added doveadm_killed_signo()

doveadm: Removed unused doveadm_mailbox_find_and_sync() function

dsync: Stop running if SIGINT/SIGTERM is received.

doveadm: Changed -U to -F Otherwise -U collides with doveadm sync -U parameter. -F isn't currently used by anything.

doveadm: Added -U <file> parameter for executing the command for all the users in the file. This is similar to -A parameter, but instead of getting the list of users from userdb they are read from the file. The file contains one username per line.

doveadm-server: Fixed returning command input stream when its data was already in the input stream.

doveadm: Added "save" command to directly save mail to specified mailbox. The mail is read from stdin.

doveadm: Added support for mail commands to read an input stream (from stdin) This is done by calling doveadm_mail_get_input() from the command's init() function. Currently it reads the entire input into a seekable istream with hardcoded 5 minute timeout. The input stream sending works also through doveadm proxying. This could probably be used by dsync at some point to support proxying over doveadm proxies, but that would require some more work. Especially a flag for commands to specify that they allow non-blocking input streams.

doveadm: Reverted changeset 3b89f2f4ffb3, which avoided calling init() for proxied commands. The init() is required for all commands that print something, because otherwise the doveadm_print_header*() isn't called and the commands crash. The reason for the original change was that some commands' init() attempted to do too much work on the proxy, which ended up failing. So looks like the proper fix is to just remove this kind of extra work from init().

doveadm: Added missing error handling to various mail commands. This fixes assert-crash that happened when the commands failed, because they hadn't set any exit_code.

doveadm: If mailbox list iteration fails, log the error reason.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

doveadm: Avoid calling init() in doveadm binary if the command is sent to doveadm-server. The init() is still always called when -A or -u *wildcards* are used though. I'm not sure if that can be delayed. At least all commands should be verified that they don't rely on the current init() location.

doveadm: Added metadata set/unset/get/list commands.

dsync: Moved doveadm-specific code to doveadm directory.

Handle "out of disk space" and "out of user quota" as separate cases. "Out of disk space" is a temporary error that should be logged as error and the failure should be sent to user as "Internal server error". Obsolete the use of MAIL_ERROR_NOSPACE and MAIL_ERRSTR_NO_SPACE. Use the clearer MAIL_ERROR_NOQUOTA and MAIL_ERRSTR_NO_QUOTA instead.

various - trivial NULL-related sparse cleanups These zero-alikes are all pointers, so should explicitly be NULL. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.