doveadm: Add new "stats dump" command

global: Renamed stats plugin and service to old-stats

global: drop unnecessary parens in &(foo) This makes the code more consistent since most of the repo uses the no-parens style. These inconsistencies were found using `git grep '(&([^*]'` and any use of the parens in macros was ignored for safety reasons.

doveadm: Reorder includes This makes next commit possible

doveadm: "Extraneous arguments found": Show the args in the error

doveadm: Make sure positional arguments end up in right place Otherwise -- is placed into wrong place and breaks command line reparsing in legacy functions.

doveadm: Add exit code/string conversion functions

doveadm: Ensure -- is added to command line before positional arguments for non-mails commands as well Was forgotten from 967efe37d1f10a28c0a086cc5919d4ce8917bed8

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

Added "doveadm process status" This allows asking for processes' current status in master process.

Added "doveadm service status" This allows asking for services' current status in master process.

doveadm: Added "service stop" command to stop specific services.

doveadm: Implement user and auth cache flush to server

doveadm: Fixed --long-parameters handling

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: Fixed mismatched bool vs. int/pointer handling I don't think these fix any actual bugs.

lib-master, doveadm: remove mountpoint-list.* and doveadm mount commands

doveadm-server: Fixed running multi-word commands. The problem with for example "mailbox status" command is that: - doveadm cli: argv[0] = "mailbox", argv[1] = "status" - doveadm-server: argv[0] = "mailbox status" So with doveadm cli we'll now instead just skip over words until argv[0] is the last word of the command ("status").

doveadm: Code cleanup - always use const char *const[] type for argv. Needed to fix compiler warnings in the following patch.

doveadm: A bit nicer way to implement doveadm_cmd_param_array() returning C-string array So replacement of 4afc67eb9, which I accidentally pushed before remembering about this other way.

doveadm-kick: Rewrite to ver2 infra

doveadm-who: Rewrite to ver2 infra

doveadm: Changed doveadm_cmd_param_array() to return C-string array instead of ARRAY() We could support both with separate functions, but perhaps this one is enough.

doveadm-cmd: Support non-strings in compat wrapper

doveadm: Changed v2 command APIs to be easier to use.

doveadm: Code cleanup - Removed unnecessary pointer checks. Originally for some reason added by e16cdc182.

doveadm: Add more consts to avoid a cast breaking strict-aliasing rules.

doveadm: Added struct doveadm_cmd_attributes, which is passed around instead of argc/argv

doveadm-penalty: Convert to ver2 infra

doveadm: Code cleanup - coding style fixes for doveadm_cmd_param*() accessors

doveadm-cmd: Add CMD_PARAM_IP

doveadm: Remove return value from ver2 cmd() - doveadm_exit_code is enough

doveadm-cmd: Constify doveadm_cmd_param_*() usage

doveadm: Added doveadm_cmd_get_ver2() helper

doveadm: Free istream parameters everywhere Based on patch by Aki Tuomi

doveadm: Minor code cleanup - rename doveadm_cmd_find*() to doveadm_cmd_find_with_args*()

doveadm: Code cleanup - remove unnecessary NULL sets and checks

doveadm: Fixed memory leak at deinit

doveadm-stats: Use ver2 structures

doveadm: Fixed using array type parameters.

doveadm: Fixed assert-crash when command with CMD_PARAM_FLAG_DO_NOT_EXPOSE was used.

doveadm: Fixed support for --long-option arguments

doveadm: Fix for previous attempt to make static analyzer happier.

doveadm: Make static analyzer happier - cptr can't be NULL here.

doveadm: Use char type for short options instead of a string. The ":" = "has parameters" can be determined from the type. Also removed "?" checks since it wasn't actually used.

doveadm: Remove CMD_PARAM_NONE type, since it already defaulted to same as CMD_PARAM_BOOL

doveadm: Use ver2 structures for stop & reload.

doveadm: Add infrastructure for doveadm_cmd_ver2 Version 2 commands have named parameters, which also have types. This is especially useful for reading input from HTTP/JSON API. This also simplifies the parameter parsing for command line input. For v2.3 the plan is to replace all the old doveadm_cmds with this new version and get rid of the _ver2 suffixes. But for now we'll have two versions of commands. For backwards compatibility with old commands we have also implemented wrappers so that v2 structs can be defined and there's a function to convert the named parameters to old v1 style args[] string, so the old command handlers can still be run. This will also be removed in v2.3. This change also adds requirement for getopt_long(). It's already available in all the Linuxes and BSDs, so this shouldn't be too big of a requirement. Other systems can install it from an external library.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

doveadm: Moved commands related code to doveadm-cmd.[ch] Commands are already split for command line-only commands and commands that can be run via doveadm-server also.