Updated copyright notices to include the year 2018.

global: Rename client_connection_type to doveadm_connection_type

doveadm: Rename client_connection_type to doveadm_client_connection_type Move it to doveadm.h to allow plugins use doveadm-cmd.h

doveadm-server: Restructured client-connection code so that TCP and HTTP connection types are properly separated.

doveadm-server: Moved common client code back from client-connection-tcp.c to client-connection.c.

doveadm: mail: Removed redundant cur_username field from struct doveadm_mail_cmd_context.

doveadm: mail: Removed struct doveadm_cmd_context function parameters that are now useless. It can be accessed from struct doveadm_mail_cmd_context.

doveadm: Changed command contexts to contain the input, output, and connection type values directly. Before, it used a direct pointer to the connection. It used also flags to indicate the connection type, which is now consolidated in the connection type enum.

doveadm-server: Remove flush before multiplex It's not really necessary, found by coverity

doveadm-server: Use i_close_fd

doveadm: Deliver remote logs over doveadm socket

doveadm: Refactor server/client code to support versioning properly This way we can distinguish between old and new server side

doveadm-server: Refactor connection handshake and authentication Simplifies next change

global: start relying on [io]_stream_destroy(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_destroy(&E); - } + i_stream_destroy(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_destroy(&E); - } + o_stream_destroy(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

lib: lib-signals: Removed explicit notification of ioloop change through lib_signals_reset_ioloop() in favor of implicit method. Before, if the ioloop changed, the application had to explicitly notify lib-signals using lib_signals_reset_ioloop(). This is error-prone and requires doing this all over the Dovecot code base. Now, lib-signals registers an ioloop switch callback that deals with this implicitly. The application can detach lib-signals from the ioloop explicitly if delayed signal handling is not required/desired in the new ioloop. Specific delayed signal handlers can be exempt from this automated behavior using a flag, meaning that such signal handlers need to be moved between ioloops explicitly.

doveadm-server: http: Fixed crash occurring when disconnecting a client at server deinit.

doveadm-server: Deinitialize print on connection destroy Otherwise print remains initialized and can break when reusing the service.

doveadm: Make doveadm_password safe against timing attacks.

doveadm: Send and receive exit codes correctly The old code would assume TEMPFAIL for almost everything.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

doveadm-server: Show UNIX socket connections as <local> in process title Earlier they were shown as empty string.

global: Code cleanup - Use t_strsplit_tabescaped() to avoid str_tabunescape()

doveadm-server: Show incoming connection's IP and running command is process title.

doveadm-server: Reset error code between calls

doveadm: Fixed -A and -u wildcard handling with server connections.

doveadm: Pass connection to mail context

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

doveadm-server: Fixed running multi-word commands. The problem with for example "mailbox status" command is that: - doveadm cli: argv[0] = "mailbox", argv[1] = "status" - doveadm-server: argv[0] = "mailbox status" So with doveadm cli we'll now instead just skip over words until argv[0] is the last word of the command ("status").

doveadm: Code cleanup - always use const char *const[] type for argv. Needed to fix compiler warnings in the following patch.

doveadm-server: Fixed initializing username for mail commands.

doveadm-mail: Rename ctx to mctx to separate from cctx

doveadm: Changed v2 command APIs to be easier to use.

doveadm: Fixed command parameter handling for doveadm-server.

doveadm: Pass through mail_storage_service_input fields in doveadm_cmd_attributes

doveadm: Added struct doveadm_cmd_attributes, which is passed around instead of argc/argv

doveadm: Minor code cleanup - rename doveadm_cmd_find*() to doveadm_cmd_find_with_args*()

doveadm-http: Close client input correctly

doveadm: Compiler warning fix.

doveadm: Implement HTTP server API, slightly based on JMAP API

doveadm: Code cleanup - moved code to client_connection_init() No functional changes.

doveadm: Changed most print formatters to write to ostream. This allows all the formatters to be used when sending replies to the upcoming doveadm HTTP server responses. The "table" formatter wasn't modified, because it writes to both stdout and stderr.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

doveadm: Fixed reseting getopt() with glibc when processing multiple commands in a single process. This means commands run with doveadm batch or multiple commands in a single doveadm-server connection. glibc's getopt() man page says that optind=1 should reset it for scanning a new argument vector, but this doesn't actually seem to work. Setting optind=0 does work though, so use it everywhere.

doveadm-server: Reset getopt() before calling non-mail commands. This fixes parsing their parameters when using multiple such commands within a single doveadm connection.

doveadm: Changed -U to -F Otherwise -U collides with doveadm sync -U parameter. -F isn't currently used by anything.

doveadm: Added -U <file> parameter for executing the command for all the users in the file. This is similar to -A parameter, but instead of getting the list of users from userdb they are read from the file. The file contains one username per line.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

doveadm: Support running non-mail commands via doveadm server. There are still some commands that print their output via printf though, so they need to be fixed separately.

doveadm: Code cleanups to prepare server code for non-mail commands.

doveadm-server: Using any command line parameters caused crashes due to missing getopt() reset.

Updated copyright notices to include year 2014.

Use io_loop_set_current() instead of directly setting it.

doveadm-server: Minor error message improvement.

doveadm-server: ioloop change caused assert-crashes if outgoing data was buffered at the end.

doveadm-server: Don't call io_loop_run() recursively for the same ioloop. This breaks things more or less badly, especially ioloop-kqueue really didn't like it.

doveadm-server: Error message logging improvements.

doveadm-server: Include client's IP address in logs.

dsync: Name remote connections better.

doveadm: Pass through the exit code from doveadm-server to client.

Memory leak fixes.

doveadm-server: Pass local/remote_ip/port to passdb lookups so proxy_maybe works.

lib-ssl-iostream: API changes to return error strings if init() functions fail. This also fixed a couple of broken error handlings.

doveadm-server: Don't continue handling commands if input stream is already closed. This fixes trying to handle extra input from previous dsync command.

doveadm-server: Added support for ssl listeners.

dsync: Added tcp:host[:port] target for syncing via doveadm-server.

Oops :) Update copyrights to 2013 without breaking all .c files.