Updated copyright notices to include the year 2018.

doveadm: Remove dead code ret can never be >0 at this point. If there are any unexpected JSON elements, doveadm_http_server_json_parse_v1() returns -1.

global: Replace o_stream_nfinish() with o_stream_finish() whenever possible

global: Rename client_connection_type to doveadm_connection_type

doveadm-server: http: Properly implemented error handling for requests.

doveadm-server: http: Mark the HTTP request for connection closure right away. This means that the connection is closed once the request finishes. Before, each response did that individually. Once connection reuse is implemented/needed this can now be turned off at one place.

doveadm-server: http: Restructured JSON parsing to improve code clarity. Made state machine more explicit and easier to understand. Also added more comments.

doveadm-server: http: Wrapped long code lines.

doveadm-server: http: Joined JSON parsing and handling in one function.

doveadm-server: http: Split JSON handling into several sub-functions.

doveadm-server: http: Split JSON parsing into several sub-functions.

doveadm-server: http: Changed request parse error into an assertion. The condition can never occur when json-parser and the request parsing state machine are behaving correctly. At that point only an object key can be returned; the client cannot cause it to return anything else.

doveadm-server: http: Moved doveadm_http_server_command_execute().

doveadm-server: http: Renamed parse state enum.

doveadm-server: http: Split off request handling in separate struct, so that the connection can be reused.

doveadm-server: http: Added structural comments.

doveadm-server: http: Moved doveadm_http_server_request_destroy().

doveadm-server: http: Moved doveadm_http_server_send_response().

doveadm-server: http: Moved connection-related code to the bottom of the file.

doveadm-server: http: Make http_server_set a local variable of doveadm_http_server_init().

doveadm-server: http: Create the http_response once needed, not preemptively.

doveadm-server: http: Split authentication into multiple functions.

doveadm-server: http: Renamed conn->http_server_request to conn->http_request.

doveadm-server: http: Removed http_request field from struct client_connection_http. Not useful to put it there.

doveadm-server: http: Renamed conn->http_client to conn->http_conn.

doveadm-server: Restructured client-connection code so that TCP and HTTP connection types are properly separated.

doveadm-server: http: Moved client_connection_destroy_http().

doveadm-server: http: Renamed client_connection_create_http() to client_connection_http_create().

doveadm-server: http: Renamed conn->client to conn->conn.

doveadm-server: http: Changed index variables from size_t to unsigned int where size_t makes no sense.

doveadm-server: http: Changed initialization of parameters in doveadm_http_handle_json_v1(). Use normal assignment, rather than memcpy(). This way, type checking is not skipped unnecessarily.

doveadm-server: http: Use `ret' rather than `rc' as name for the local variable used for return values.

doveadm-server: http: Cleaned up code formatting.

doveadm-server: http: Created local variable for conn->cmd_param->value.v_istream as an abbreviation. This is a preparation for subsequent commits.

doveadm-server: http: Created local variable for conn->client.output as an abbreviation. This is a preparation for subsequent commits.

doveadm-server: http: Created local variable for conn->http_request as an abbreviation. This is a preparation for subsequent commits.

doveadm-server: http: Created local variable for conn->http_response as an abbreviation. This also makes sure it is named consistently everywhere. This is a preparation for subsequent commits.

doveadm-server: http: Created local variable for conn->http_server_request as an abbreviation. This also makes sure it is named consistently everywhere. This is a preparation for subsequent commits.

doveadm-server: http: Moved loop body in doveadm_http_server_read_request_v1() to separate function.

doveadm: Changed command contexts to contain the input, output, and connection type values directly. Before, it used a direct pointer to the connection. It used also flags to indicate the connection type, which is now consolidated in the connection type enum.

doveadm-server: http: Fixed lingering connections after the request is sent. Turns out conn->http_client is already NULL while doveadm_http_server_connection_destroy() is called. This is because http_server_connection_unref() sets it to NULL; Fixed by removing useless HTTP connection reference.

lib: lib-signals: Removed explicit notification of ioloop change through lib_signals_reset_ioloop() in favor of implicit method. Before, if the ioloop changed, the application had to explicitly notify lib-signals using lib_signals_reset_ioloop(). This is error-prone and requires doing this all over the Dovecot code base. Now, lib-signals registers an ioloop switch callback that deals with this implicitly. The application can detach lib-signals from the ioloop explicitly if delayed signal handling is not required/desired in the new ioloop. Specific delayed signal handlers can be exempt from this automated behavior using a flag, meaning that such signal handlers need to be moved between ioloops explicitly.

doveadm-server: http: Fixed crash occurring when disconnecting a client at server deinit.

spelling fixes

doveadm: add doveadm_http_rawlog_dir setting

global: Update http_server_request_set_destroy_callback usage

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

doveadm-server: http: Fixed temp_path_prefix for iostream-temp. The temp_path_prefix was "/tmp", which is extended to "/tmp<hostname>.<pid>.<random>" by safe_mkstemp. Obviously, mortal users cannot create a file like that, causing this error: doveadm: Error: safe_mkstemp(/tmp) failed: Permission denied The temp_path_prefix should have been "/tmp/doveadm.", as it is elsewhere as well.

doveadm-server: Show incoming connection's IP and running command is process title.

global: Make sure i_stream_read() calls handle 0 and -2 return values correctly.

doveadm-server: Do not crash if empty data in authorization

doveadm-server: Skip doveadm_print_init Some commands need to do output that is not doable with doveadm_print, so we need to have a flag to indicate this.

doveadm-server: Disable idle timeout for now

global: Use o_stream_nsend_istream() where useful We can skip all of the io error handling and just leave it to o_stream_nfinish().

doveadm-server: Handle istream send error.

doveadm-http: Fix mismatch in authorization The code advertizes X-Dovecot-API in WWW-Authenticate header, but expects X-Doveadm-API in Authorization header. This change makes it expect X-Dovecot-API.

doveadm: Fix typos in error messages

doveadm-http: Fixed crash when no authentication was configured.

doveadm: Don't treat doveadm_api_key differently when it's unset vs set to empty.

doveadm-http: Minor logging improvement - indicate error source

doveadm-http: Drop surplus log prefix

doveadm-http: Set HTTP client's max idletime to 5 seconds

doveadm-http: For each executed command, log the command name and the user parameter if given.

doveadm-http: Improve authentication related code

doveadm-http: Code cleanup - Move authorize to its own function

doveadm-http: Add API calls and versioning for v1

doveadm: A bit nicer way to implement doveadm_cmd_param_array() returning C-string array So replacement of 4afc67eb9, which I accidentally pushed before remembering about this other way.

doveadm: Changed doveadm_cmd_param_array() to return C-string array instead of ARRAY() We could support both with separate functions, but perhaps this one is enough.

doveadm-http: Fixed crash on unknown commands. Also if command had already failed, don't override the existing method_err with 403.

doveadm: Changed v2 command APIs to be easier to use.

doveadm: Pass through mail_storage_service_input fields in doveadm_cmd_attributes

doveadm-cmd: Add CMD_PARAM_IP

doveadm: Remove return value from ver2 cmd() - doveadm_exit_code is enough

doveadm: Code cleanup - remove duplicate code

doveadm: Free istream parameters everywhere Based on patch by Aki Tuomi

doveadm: Code cleanup - remove unnecessary NULL sets and checks

doveadm-http: Close client input correctly

doveadm-http: Return HTTP failure on unexpected JSON input

doveadm-http: Handle invalid input better for arrays.

doveadm-http: Handle istreams correctly Based on patch by Aki Tuomi

doveadm-http: Correctly initialize parameters

doveadm: Remove CMD_PARAM_NONE type, since it already defaulted to same as CMD_PARAM_BOOL

doveadm: Use correct uoff_t type for printf

doveadm: Implement HTTP server API, slightly based on JMAP API