Updated copyright notices to include the year 2018.

global: timeout_remove(NULL) is a no-op

director: Don't send USERs in handshake that were already sent between handshake If the user was refreshed since the handshake was started, it means that the same user was already sent to the other side (added to the stream immediately after it was received/handled). There's no need to send it again. This fixes a potentally infinite handshake when users are rapidly changing and the handshake iterator never sees the end of the list. (Each refreshed user is moved to the end of the list, so handshaking can keep sending the same user over and over again.)

director: Delay sorting users until there are no more user iterators This shouldn't have normally happened. Only when an outgoing handshake was going on at the same time as a) another outgoing handshake was going on, or b) doveadm was doing HOST-RESET-USERS

director: Keep users unsorted during handshake and sort them at the end This is simpler and sometimes more efficient than the current way of immediately inserting the users to the correct place in the linked list. This is especially useful if handshaking is mixed with regular USER updates, because each switch between them required walking the linked list backwards to find the proper insert position. It's not a big problem if the users list is temporarily unordered. It mainly means that some of the users won't be expired as early as they should have.

director: Don't recreate timeout on every user lookup Recreate it only when the timeout should change.

director: Fix off-by-one when checking if user weakness is stuck When the weakness was exactly at the second, the weakness wasn't detected and the next expiration timeout was removed entirely. This shouldn't have caused any bigger problems, because another user lookup on the following second would have then detected the weakness, removed the user and restored the next expiration timeout.

director: Make sure users gets expired even on an idle director Normally expiring gets done while looking up users, but if nothing is doing that on an idle director the users won't get expired. This can cause confusion in "doveadm director status" output.

Updated copyright notices to include the year 2017.

director: Code cleanup - typedef user_free_hook This is done because user_free_hook needs to be also used in mail_host. If it changes, this reduces the places that need touching.

director: Code cleanup - Reorder includes This is required to enable typedef of user_free_hook

director: Code cleanup - moved username_hash generation to director.h It's not really user_directory specific. This is especially important in the following patches that add per-tag user_directories. It's also not always known which tag the username_hash refers to, so there can't be different tag-specific username_hash generators.

lib: API change - var_expand*() now returns error string. This allows callers to fail properly if the format string is invalid.

director: Moved all user killing state to struct director_kill_context This should make it a bit easier to understand the life time of user killing. It also simplifies code by removing struct director_user_kill_finish_ctx. Finally, this already reduces memory usage with 32bit systems, and would make it possible to reduce also on 64bit systems if timestamp is shrank to 31 bits and weak bit moved after it. I'm not sure if that would be better for performance though. In any case it would provide free space for 4 extra bytes if that were needed in future.

director: Code cleanup - added USER_IS_BEING_KILLED() macro

director: Code cleanup - move enum user_kill_state to director.h This will be needed by following commits

director: Prevent race conditions by adding USER_KILL_STATE_FLUSHING In theory it's possible that a user is freed during a flush and added back before flush is finished, possibly even being moved again. This check makes sure that we don't finish such move unless we're actually at the correct flushing state. (If there's another flush also running for the user it'll be ignored.) This is also useful for logging purposes.

director: Log user's kill_state with a human-readable string.

director: Make sure freeing a user doesn't leak a timeout.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

director: Include useful statistics in process title.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

various - trivial NULL-related sparse cleanups These zero-alikes are all pointers, so should explicitly be NULL. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

Make static analyzer happier.

director: Update existing users' timestamps during handshake.

director: Expire users a bit more correctly. Also make sure that the "user near expiring" interval is at least 3 seconds in case director_user_expire is very low.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.

director: If user's weak-flag appears to have gotten stuck, unset it.

Compiler warning fixes for 32bit systems.

Reverted "support for non-pointers" part of the hash table API changes. Originally I wrote it using clang, which didn't give as many warnings as gcc did. I guess this way is safer anyway..

Array API changed: ARRAY_DEFINE(name, type) -> ARRAY(type) name Easy way to update your existing code: perl -i -pe 's:ARRAY_DEFINE\(([^,]+), *([^)]+)\);:ARRAY($2) $1;:' **/*.[ch]