| 9d47b3d53a3ecacfe07d03e5b2339e6043e0f48e |
|
27-May-2014 |
Phil Carmody <phil@dovecot.fi> |
auth: checkpassword callback callback type bike-shedding
This change doesn't change the compiler's (gcc) view on the correctness of
the code. It moves sparse's attention of where the potential issues are
though. Sparse used to complain about dodgy function pointer conversions on
both the way out (passing the callback function pointer), and on the way in
(entering the callback). Making the callback not lie about what it receives
gets rid of the way in warnings, but adds warnings as we pass the new
function pointer out. However, it already complains about that call anyway.
So it complains about 6 things in 3 functions rather than 6 things in 6
functions.
Of dubious worth, but it at least reduces the number of lines you need to
inspect to verify correctness.
Signed-off-by: Phil Carmody <phil@dovecot.fi> |