global: start relying on [io]_stream_destroy(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_destroy(&E); - } + i_stream_destroy(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_destroy(&E); - } + o_stream_destroy(&E);

auth: Fixed dovecot/auth hanging when child ntlm_auth crashes while processing an authentication request

global: Use [io]_stream_get_error() insted of %m

Remove now-unnecessary direct stdlib.h #includes.

auth: Mark memory pools as growing and use the same sizes for all mechanisms. Mainly to have DEBUG log fewer warnings.

Use the new [io]_stream_create_fd_*autoclose() functions wherever possible.

auth: Use special AUTH_SUBSYS_DB/MECH parameters as auth_request_log*() subsystem. This avoids hardcoded strings all over the place and also allows assigning the correct passdb/userdb name for log messages generated by generic passdb/userdb code, which doesn't know exactly where it was called from.

auth: Fixed also DOVECOT-TOKEN (=URLAUTH) and NTLM/GSS-SPNEGO (via winbind) to work.

auth: winbind mechanism supports now spaces in filenames.

Changed i_close_fd() API to set the fd to -1 after closing.

Replaced (void)close(fd) and close_keep_errno() with i_close_fd(). i_close_fd() preserves the errno and logs an error if the close() fails.

Added o_stream_nsend*() and related functions to make delayed error handling safer. Once o_stream_nsend*() is called, o_stream_nfinish() must be called before stream is destroyed to finish checking if there were any errors. If something failed and the stream is just wanted to be closed, o_stream_ignore_last_errors() can be called. For streams where errors don't really make any difference (network sockets) you can call o_stream_set_no_error_handling() immediately after creating the stream.

Marked functions parameters that are allowed to be NULL. Some APIs were also changed. The non-obvious APIs where NULL parameter was changed to "" are master_service_init() and auth_master_user_list_init(). These checks can currently be enabled only on a patched clang: http://llvm.org/bugs/show_bug.cgi?id=6786

Use SA_RESTART flag for signals wherever possible. Only SIGTERM (and SIGINT for standalone programs) shouldn't use it.

auth: Fixed mech_winbind_ntlm by using mech_winbind_auth_initial() In changeset 9002 a new function named mech_winbind_auth_initial() was introduced, but only the mech_winbind_spnego module part was changed to finally use this function. The mech_winbind_ntlm module part was not properly adapted which leads to a non functioning NTLM authentication mechanism while using winbind, because it will never call the `ntlm_auth` helper. The simple fix is to replace mech_generic_auth_initial() with mech_winbind_auth_initial() as auth_initial "hook" when setting up the mech_winbind_ntlm module, like it is done in the mech_winbind_spnego module. References: - Changeset 9002: http://hg.dovecot.org/dovecot-2.0/diff/9d0037a997f4/src/auth/mech-winbind.c --- src/auth/mech-winbind.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

auth: Removed unnecessary auth_request callback and context uses. --HG-- branch : HEAD

Small code changes to make static analyzer happier. --HG-- branch : HEAD

Replaced execv*() with execv*_const() wherever possible. --HG-- branch : HEAD

auth: Initial support for per-protocol auth settings. Currently the list of services is hard-coded. This should be changed so that config lookup returns the service names. --HG-- branch : HEAD

Removed MEMBER() macro. Require C99 style struct initializer. --HG-- branch : HEAD

Renamed headers to prevent collision if they were flattened on an install. --HG-- branch : HEAD

lib-signals: Changed callback API to return siginfo_t. --HG-- branch : HEAD

Initial commit for config rewrite. --HG-- branch : HEAD

auth: Code cleanup for specifying what passdb features auth mechanisms need. --HG-- branch : HEAD

Added support for userdb checkpassword. Patch by Sascha Wilde. --HG-- branch : HEAD

Renamed __attr_*__ to ATTR_*. Renamed __attrs_used__ to ATTRS_DEFINED. --HG-- branch : HEAD

One more pid fix. --HG-- branch : HEAD

waitpid() fix --HG-- branch : HEAD

Removed bad comment. --HG-- branch : HEAD

And mark pid=-1 so restarting really works. --HG-- branch : HEAD

waitpid() ntlm_auth workers so they won't be left as zombies. --HG-- branch : HEAD

Assert-crashfix. --HG-- branch : HEAD

Removed unused include. --HG-- branch : HEAD

Renamed auth_winbind_helper to auth_winbind_helper_path. --HG-- branch : HEAD

Added support for Samba's ntlm_auth helper. It's used for GSS-SPNEGO mechanism. If auth_ntlm_use_winbind=yes it's also used for NTLM mechanism. Patch by Dmitry Butskoy. --HG-- branch : HEAD