Updated copyright notices to include the year 2018.

global: start relying on [io]_stream_close(NULL) being a no-op Cleanup performed with the following semantic patch (and a bit of hand-editing): @@ expression E; @@ - if (E != NULL) { - i_stream_close(E); - } + i_stream_close(E); @@ expression E; @@ - if (E != NULL) { - o_stream_close(E); - } + o_stream_close(E);

global: use i_close_fd{,_path}() instead of open-coding them

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

auth: Use mem_equals_timing_safe() for all password hash comparisons. It's unlikely these could be used to perform timing attacks, since the attacker would have to have broken MD5/SHA badly enough to be able to quickly generate string that result in wanted hashes. Still, the extra cost is almost nothing and it's always better to be super paranoid!

Updated copyright notices to include the year 2017.

global: Replaced t_strsplit_tab() calls with t_strsplit_tabescaped() This is useful especially in auth code to support LFs in extra fields. Other pieces of code were also tab-escaping strings, but never unescaping them. Usually it didn't matter, because nobody would use the escaped characters. Still, the code wasn't exactly behaving correctly. One downside to this change is that it's now possible to pass through TABs, CRs and LFs through the various protocols. In theory this shouldn't cause any problems, but combined with other bugs this could trigger some security problems.

global: Added uchar_empty_ptr and use it instead of &uchar_nul. This makes Coverity happier about not treating a char as an array. For now this is a pointer to a 0, but could as well become a pointer that crashes if dereferenced. Shouldn't be NULL anyway because clang's -fsanitize=nonnull-attribute will complain about them.

auth: Skip authentication with noauthenticate

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

global: Fixed mismatched bool vs. int/pointer handling I don't think these fix any actual bugs.

auth: Code cleanup - avoid using void *context auth_request_callback_t always uses struct auth_client/master_connection* in the context - no need to try to be too generic here.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

auth: Typofix for error message.

Remove now-unnecessary direct stdlib.h #includes.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

auth: Some unsuccessful passdb lookups weren't returned as failures to passdb lookups. These lookups were only being done internally, so it usually didn't matter. Also this only affected things like allow_nets checking and some non-common passdb { result_* } settings.

auth: Make sure userdb iteration is destroyed if worker connection disconnects.

auth: protocol-specific username settings weren't used for userdb lookups. The username was set before the service-specific settings were looked up, so global settings were always used. This affected auth_default_realm, auth_username_translation and auth_username_format settings.

auth: master-connection - bail on malformed list If master is not communicating to us in a syntax we understand, just ask for it to be unplugged. This changes the behaviour in this error case. Previously, we returned -1, which is TRUE when converted to a boolean, and thus this changes the error semantics, and may be horribly wrong. However, the i_error()s in auth_master_input_line follow the same pattern. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

auth: Added userdb result_success/failure/tempfail and skip settings, similar to passdb's.

auth: Crashfix to "doveadm auth cache flush" when auth cache was disabled

auth: Return a reason string if PASS lookup fails because passdbs don't support it.

auth: Don't crash with "doveadm auth cache flush" when cache is disabled.

auth: Fixed user iteration hang due to earlier stream corking changes. Also fixed process title updating for auth-worker process during LIST.

auth: Use fewer syscalls for sending user list.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.